Mod Archive Forums
Music Production => MilkyTracker Bug Reports => MilkyTracker => Tracking => Bug Report Archive => Topic started by: Subi on April 05, 2012, 18:09:27
-
Just found this while I was doing my MOD for Revision. With Options->Playback Mode set to PT 2.x Milky lets me save MODs with samples that are 128K (0x1ffff), but PT can only handle samples of 64K (0xffff) as I was reminded when I tried the finished MOD on an A1200. :)
-
I wouldn't even say that this is a bug, since a play mode shouldn't influence how samples are stored in the file. Though one could of course think about actually only playing the first 64k of samples in that mode.
-
True, but the bug for me is that it let me save the MOD with samples over 64k but under 128k, while not letting me save with samples over 128k. It's trying to help me make a valid Amiga MOD, it's just using the wrong value. :)
-
You technically cannot save samples > 128k in MOD files.
-
You technically cannot save samples > 128k in MOD files.
You technically cannot save samples > 64k in MOD files, but Milky only warns you if they're over 128k, that's my point. :)
-
You technically cannot save samples > 64k in MOD files
That's not true. The sample length field is 16 bits wide, but the lowest bit of the sample length is not stored. Effectively, that means that you can only save samples whose length is a multiple of 2, and furthermore, it means that you can save samples that are up to 1FFFF bytes (or 128K) instead of FFFF bytes (or 64K) long. Most Amiga trackers don't support sampels that are longer than 64K bytes, but there is nothing wrong with storing them in the file. It is technically perfectly possible, it's just that Amiga trackers can't handle it.
-
Surely "Not handled by Amiga trackers" should count for something when trying to write authentic MODs?
-
See, I do agree with you here from the very first post, but as said in my first reply already - this shouldn't be handled by a play mode. Maybe there should be a special save mode that only allows you to write out 4 channel MODs with 64k samples only. The point is that using the ProTracker play mode might even be desirable for "PC mods", so it shouldn't depend on the play mode whether large samples are allowed or not.
-
Ah, I see what you mean now. Maybe it could look at the bitrate of the sample and only allow 64k if the sample is 8-bit?
-
That would be too intransparent and hard to understand, since all samples are converted to 8-bit for MOD anyway (MOD cannot save 16-bit samples). As said, adding a "Amiga MOD" save mode to the already existing save modes (XM, MOD, WAV) would be the easiest to understand and easiest to use way - but it's up to the milky guys if they want to do it like this.
-
Since MOD is predominantly used for Amiga modules, I have modified the MOD exporter to limit sample sizes to 64k.
-
I think this could be handy but should be optional. Why limit editing/making non-Amiga MODs? It's 20+ years too late. ;)
-
What is a non-Amiga mod anyway? Surely you'd use .XM for anything on the PC.
Creating .mod files that aren't compatible with Protracker/Amiga is like creating .XM files that aren't compatible with FastTrackerII!
-
Well, people create MOD files for all kinds of reasons, being able to play them with ProTracker isn't always one. Also keep in mind that there's ProTracker for Atari platforms for example, not sure if there's a 64k limit there, same with various Amiga replayers (since there are many Amiga trackers that can actually handle bigger samples). So yeah, as raina said, this should probably be optional. Especially when considering MOD files with more than 4 channels.
Creating .mod files that aren't compatible with Protracker/Amiga is like creating .XM files that aren't compatible with FastTrackerII!
ProTracker is just a big hack upon an existing format (Ultimate Soundtracker), remember that? So why shouldn't we just limit our MODs to 1xx/2xx effects, 9kb per sample and only 15 samples? ;) MOD is a very loosely defined format, there are many variations of it and many programs that support it, and while ProTracker might have been the most common tool on the Amiga to create MODs, there are dozens of other popular MOD trackers out there.
-
I've changed it to display a warning when samples are over 64k in size, but limit the sample size to 128k (the maximum possible in the mod format).