Mod Archive Forums Mod Archive Forums
Advanced search  

News:

Please note: Your main modarchive.org account will not work here, you must create a forum account to post on the forums.

Pages: 1 [2] 3   Go Down

Author Topic: PeePeePlayer - old-fashioned S3M player  (Read 14977 times)

0 Members and 1 Guest are viewing this topic.

Saga Musix

  • TMA Moderator
  • Too much pie
  • *****
  • Offline Offline
  • Posts: 2173
  • I love OpenMPT! And Modules! And TMA! And Pie! :>
    • View Profile
    • Saga Musix - free module music and more!
Re: PeePeePlayer - old-fashioned S3M player
« Reply #10 on: July 27, 2012, 18:59:13 »

Hmm, that particular page was created about three weeks ago, not too long ago actually. ;D It's heavily inspired by this page, though, so you maybe had that in mind.
Logged
» My TMA artist profile
» Visit my music site: https://sagamusix.de/ [de, en]
» Visit my programming website: https://sagagames.de/ [de]
» Open ModPlug Tracker

Sto

  • Devouring the Pies
  • Offline Offline
  • Posts: 20
    • View Profile
    • Github
Re: PeePeePlayer - old-fashioned S3M player
« Reply #11 on: July 27, 2012, 21:30:28 »

Yes, you're right, thanks. It's hard to check the tests, but at least I definetly pass the "infinite loop" test ;)

// Edit: Around 40% passed, and 20% partly passed, seems like I've got some work to do...
« Last Edit: July 27, 2012, 23:49:19 by Sto »
Logged

Saga Musix

  • TMA Moderator
  • Too much pie
  • *****
  • Offline Offline
  • Posts: 2173
  • I love OpenMPT! And Modules! And TMA! And Pie! :>
    • View Profile
    • Saga Musix - free module music and more!
Re: PeePeePlayer - old-fashioned S3M player
« Reply #12 on: July 28, 2012, 00:55:09 »

Yes, you're right, thanks. It's hard to check the tests, but at least I definetly pass the "infinite loop" test ;)
Which parts in particular are hard to check? I want this test suite to be as easily usable as possible, so if you have any suggestions on how to improve some tests, please do tell.

I know some of the older test cases are not very good and the descriptions are probably even worse, but if I know which ones are difficult in particular I will focus on improving these.
Logged
» My TMA artist profile
» Visit my music site: https://sagamusix.de/ [de, en]
» Visit my programming website: https://sagagames.de/ [de]
» Open ModPlug Tracker

Sto

  • Devouring the Pies
  • Offline Offline
  • Posts: 20
    • View Profile
    • Github
Re: PeePeePlayer - old-fashioned S3M player
« Reply #13 on: July 28, 2012, 01:30:53 »

Which parts in particular are hard to check?

The problem is simply that I cannot really debug my player, I am currently comparing the results of FT2 and the generated mp3's.with my ears, though I am already thinking about how to automate this (e.g. write as WAV and see how this differs to the original one). The main problem is that I never used FT2, and that some of the XMs are quite fast or have pretty random things within it so I can't tell if the result is OK or not.

I think it would be cool if some musician would sit down and combine all the corner cases into one cool track so that it's easier to tell when something sounds wrong ;)

// Edit: OK, most of my post is completely stupid, I haven't read the text on the page and only downloaded the mods, so ... my fault, sorry.
« Last Edit: July 28, 2012, 01:48:19 by Sto »
Logged

Saga Musix

  • TMA Moderator
  • Too much pie
  • *****
  • Offline Offline
  • Posts: 2173
  • I love OpenMPT! And Modules! And TMA! And Pie! :>
    • View Profile
    • Saga Musix - free module music and more!
Re: PeePeePlayer - old-fashioned S3M player
« Reply #14 on: July 28, 2012, 14:10:30 »

Quote
I think it would be cool if some musician would sit down and combine all the corner cases into one cool track so that it's easier to tell when something sounds wrong
That has been done before and believe me, it's the worst way to determine whether something is correct or not. First off,you have to sit through the whole damn thing to check whether everything plays correctly. And secondly, you can not exploit every bug in a way so that it is extremely obvious that it is played back correctly.

I think playing back the (suppsedly) same stuff on the left and right channel is a far better way (in all cases it should be really obvious if your player does something wrong), and if the test is too fast, you can always render it to WAV and play it at half the frequency or something. And yes, the description texts are important to get an idea what the test is all about and what it should sound like.
Logged
» My TMA artist profile
» Visit my music site: https://sagamusix.de/ [de, en]
» Visit my programming website: https://sagagames.de/ [de]
» Open ModPlug Tracker

Sto

  • Devouring the Pies
  • Offline Offline
  • Posts: 20
    • View Profile
    • Github
Re: PeePeePlayer - old-fashioned S3M player
« Reply #15 on: July 29, 2012, 06:29:40 »

I'm sorry for the not so good things I wrote, I was pretty tired, and an average room temparature of 27 degrees celcius due to the summer were the reasons for that. But back to topic: I wrote a small python script to automatically compare two WAVs, so that the testing could maybe automated (I recently added WAV export for that): http://earvillage.square7.ch/downloads/wav_compare.py - maybe you could use it for openMPT as well.
Logged

Saga Musix

  • TMA Moderator
  • Too much pie
  • *****
  • Offline Offline
  • Posts: 2173
  • I love OpenMPT! And Modules! And TMA! And Pie! :>
    • View Profile
    • Saga Musix - free module music and more!
Re: PeePeePlayer - old-fashioned S3M player
« Reply #16 on: July 29, 2012, 13:43:41 »

That sounds very interesting, I'll have a look at it. I previously had the same idea to automate test case verification, the only drawback is probably that it relies on the render settings (interpolation and the like) to be exactly the same every time you run the test.
Logged
» My TMA artist profile
» Visit my music site: https://sagamusix.de/ [de, en]
» Visit my programming website: https://sagagames.de/ [de]
» Open ModPlug Tracker

Sto

  • Devouring the Pies
  • Offline Offline
  • Posts: 20
    • View Profile
    • Github
Re: PeePeePlayer - old-fashioned S3M player
« Reply #17 on: July 29, 2012, 13:50:32 »

Well, I discovered a major issue... my player's output is 2 times louder than the ft2 output, but the tool shows only a difference of 0.4%. Additionally, it is pretty slow (nearly realtime :(). I think I will write a small cpp to gain more speed and to be able to add some additional parameters like multiplying the samples from one .wav with a factor or the tuning of the comparison method (like "ignore length diff" or switch between mean difference and root mean square).
Logged

Saga Musix

  • TMA Moderator
  • Too much pie
  • *****
  • Offline Offline
  • Posts: 2173
  • I love OpenMPT! And Modules! And TMA! And Pie! :>
    • View Profile
    • Saga Musix - free module music and more!
Re: PeePeePlayer - old-fashioned S3M player
« Reply #18 on: July 30, 2012, 14:15:12 »

Quote
Well, I discovered a major issue... my player's output is 2 times louder than the ft2 output
You could of course normalize both outputs.
Logged
» My TMA artist profile
» Visit my music site: https://sagamusix.de/ [de, en]
» Visit my programming website: https://sagagames.de/ [de]
» Open ModPlug Tracker

Sto

  • Devouring the Pies
  • Offline Offline
  • Posts: 20
    • View Profile
    • Github
Re: PeePeePlayer - old-fashioned S3M player
« Reply #19 on: July 30, 2012, 17:18:42 »

You could of course normalize both outputs.
... which would definetly fail if there are some peaks in the output. The worst case would be a module where i.e. one envelope is calculated wrong so that one note gets played very loud - which is clearly wrong, but only one factor out of many, and here normalization would create a false positive as the difference between the waves would then increase. In my opinion that's a no-go, but I'm open for ideas.
Logged
Pages: 1 [2] 3   Go Up