Mod Archive Forums Mod Archive Forums
Advanced search  

News:

Please note: Your main modarchive.org account will not work here, you must create a forum account to post on the forums.

Pages: [1]   Go Down

Author Topic: Sample offsets broken when saving .MOD  (Read 4360 times)

0 Members and 1 Guest are viewing this topic.

Svetlana

  • Liking the Pie
  • Offline Offline
  • Posts: 3
    • View Profile
Sample offsets broken when saving .MOD
« on: December 06, 2013, 16:58:22 »

Hi, I've noticed a problem when saving .MODs under MilkyTracker .86 (I haven't noticed it in the last update, .85, so I assume it could be new.)

The samples have their offsets (data pointers?) shifted around, and a sample might have the first few bytes be the last few bytes of the previous samples. Like so:

Original file (MOD):


Milky-resaved file (MOD):


These images both show the same sample, and the bit added at the start is the end of the previous sample in the module.

Here are a couple of files, this is a song I've composed for a game using Lotus 3 samples. The song was composed in Milky by opening the original MOD and zapping the entire song to leave only the samples, I've saved it as a XM (fully abiding MOD limitations) then re-saved as MOD in OpenMPT. The second file is the song composed in Milky then saved straight to MOD. The difference is quite blatant from the first few seconds.

https://dl.dropboxusercontent.com/u/9435923/music/turbo/CD4-Cadmium.mod
https://dl.dropboxusercontent.com/u/9435923/music/turbo/CD4-Cadmium_milky.mod

Let me know if there's any more info I can provide.
Logged

Deltafire

  • Milkytracker Moderator
  • Pie Rehab
  • *
  • Offline Offline
  • Posts: 195
    • View Profile
Re: Sample offsets broken when saving .MOD
« Reply #1 on: December 07, 2013, 00:41:06 »

Fixed (github).

Thanks for the detailed bug report :)
Logged

Svetlana

  • Liking the Pie
  • Offline Offline
  • Posts: 3
    • View Profile
Re: Sample offsets broken when saving .MOD
« Reply #2 on: December 19, 2013, 18:13:11 »

Is there anywhere to download the fixed version as a binary?
Logged

Deltafire

  • Milkytracker Moderator
  • Pie Rehab
  • *
  • Offline Offline
  • Posts: 195
    • View Profile
Re: Sample offsets broken when saving .MOD
« Reply #3 on: December 20, 2013, 20:55:19 »

For which platform?
Logged

Svetlana

  • Liking the Pie
  • Offline Offline
  • Posts: 3
    • View Profile
Re: Sample offsets broken when saving .MOD
« Reply #4 on: December 24, 2013, 00:14:52 »

Windows. I'm currently using 7 x64. Would be nice to get an Mac OS X (G3) build as well, if that's at all possible. (I'm still using the old version available in the website)
Logged
Pages: [1]   Go Up